Fixing refresh config - Githubissues

codedbychavez / configcat-vue

Vue.js SDK for ConfigCat Feature Flags (community maintained)

3 stars 1 forks source link

Closed aleixmorgadas closed 1 year ago

aleixmorgadas commented 1 year ago

this.configCatClient.dispose(); was preventing the configCat to refresh the new flags
const featureFlagValue = response.settings[this.featureKey].value; wasn't considering hashed values. I changed it by another call to getValueAsync(this.featureKey, false, this.userObject) so that it evaluates the hash. As it is changed in the cache, it won't go to the network again.
I also updated it to the latest configcat version 8.1.1

codedbychavez commented 1 year ago

Hi @aleixmorgadas thanks for this. I will be taking a look.

I have also gotten some suggestions for improvements earlier this week from the ConfigCat team.

codedbychavez commented 1 year ago

Hi @aleixmorgadas, I've combined your changes with those from an engineer at ConfigCat, and it has been merged: https://github.com/chavezharris96/configcat-vue/pull/7

Looking forward to more improvements soon. Thanks so much for contributing.

aleixmorgadas commented 1 year ago

Keep pushing the library! We are using it extensively already :smile: