Todo App Project - Githubissues

codedex-io / projects

Codédex Projects 📝

https://www.codedex.io/projects

MIT License

56 stars 30 forks source link

Todo App Project #121

Closed mdwiltfong closed 9 months ago

mdwiltfong commented 9 months ago

Closes #92

[x ] My project tutorial topic has already been approved by the Codédex team.
[x ] My project tutorial file renders properly in mdx.
[x ] My .mdx file follows the project template, as well as what's recommended in the content guidelines.
[x ] The content written is my own, and not plagiarized from other sources.
[x ] All code written is thoroughly functional and commented (or documented).
[x ] I have already completed a self-review of the project tutorial.
[x ] I will comply with changes made or recommended by the Codédex team about my project tutorial.

mdwiltfong commented 9 months ago

@Dusch4593 , the link to the project-template.mdx in the contributing guide leads to a 404. I think it's just because the template is under /docs versus the root. I can fix this in this PR. Would the URL be /main/docs/project-template.mdx?

Dusch4593 commented 9 months ago

Hey @mdwiltfong! Thanks for flagging this!

No need to make that change in this PR; I went ahead and made it here in aaa906c8fb4e4b14306e619a1445ef55482fbaeb. It turned out there also needed to be an underscore in project_template.mdx (not a dash).

mdwiltfong commented 9 months ago

Whoops! I was trying to be fancy squash some of my commits but I ended up mixing some commits 😬 Nonetheless this PR is ready for review @Dusch4593 !

mdwiltfong commented 9 months ago

Thanks @Dusch4593 !

I'll go ahead and address those comments and look at the email you sent.

Dusch4593 commented 9 months ago

Thanks @Dusch4593 !

I'll go ahead and address those comments and look at the email you sent.

Sounds great, @mdwiltfong! Let us know if you have any questions! 😄

mdwiltfong commented 9 months ago

Woah! I was able to squash my commits! So proud of myself 😎

@Dusch4593 Would you be so kind to give this another review?

mdwiltfong commented 9 months ago

@Dusch4593 thanks for the comments! Let me know what you think with the changes i've made

mdwiltfong commented 9 months ago

Nice, @mdwiltfong! I actually went and looked at some of your other files as well and left some feedback there (along with a little more in the actual tutorial).

Excellent! I'll try and wrap those up during lunch.

mdwiltfong commented 9 months ago

Nice! Let me know what you guys think!

@Dusch4593 @sonnynomnom