search

codediodeio / geofirex

:globe_with_meridians: :round_pushpin: Geolocation Queries with Firestore & RxJS
https://geo-test-c92e4.firebaseapp.com/
477 stars 106 forks source link

compatibility with firebase > 8.0.0 #185

Open hgrewa opened 3 years ago

hgrewa commented 3 years ago

Any idea of how to handle the breaking change that comes with firebase 8.0.0 onward

Before 8.0.0 import * as firebase from 'firebase/app'

After 8.0.0 import firebase from 'firebase/app'

Adding geofirex to a new angular application is throwing errors like

Error: node_modules/geofirex/dist/client.d.ts:5:18 - error TS2694: Namespace '"..../node_modules/firebase/index"' has no exported member 'firestore'.

--> geopoint: fb.firestore.GeoPoint;

I tried adding "allowSyntheticDefaultImports": true to tsconfig, but that does not address the issue Is there a workaround?

jasonc624 commented 3 years ago

Need this too.

dylangolow commented 3 years ago

Any update on this coming?

lucdef commented 3 years ago

Repo seem dead. I tried to modify the source but i got an error when i execute run build:

Created bundle index.cjs.js: 23.75 kB → 6.8 kB (gzip) Created bundle index.esm.js: 23.56 kB → 6.74 kB (gzip) (!) Unresolved dependencies https://rollupjs.org/guide/en/#warning-treating-module-as-external-dependency firebase/firestore (imported by src\client.ts, src\query.ts) created dist/index.cjs.js, dist/index.esm.js in 1.3s

tzvc commented 3 years ago

I created a pull request to support firebase ^8.0.0 feel free to upvote it https://github.com/codediodeio/geofirex/pull/204

selemessaied commented 3 years ago

I created a pull request to support firebase ^8.0.0 feel free to upvote it https://github.com/codediodeio/geofirex/pull/204

How can i use your pull request in my project?

It's amazing what you did, i upvoted!

tusharvikky commented 3 years ago

Any update here?

fergardi commented 3 years ago

Is this project still maintained?

mattostanik commented 10 months ago

It has been several years since the last comment and it appears this repo is no longer maintained, but I came across this discussion while trying to get geofirex to work with a newer version of Firebase.

If it helps anyone else who also comes across this, there appears to be a fork of the package that has been updated to work with newer Firebase versions.

https://www.npmjs.com/package/@thetsf/geofirex

Thank you to the author of the fork!