codedoctor / hapi-loggly

HAPI plugin that writes logs to loggly.com
4 stars 1 forks source link

Exposed coveralls token #2

Open dsernst opened 8 years ago

dsernst commented 8 years ago

https://github.com/codedoctor/hapi-loggly/blob/master/Gruntfile.coffee#L41 exposes your coveralls token, which is meant to be kept secret. Not the biggest issue in the world — worst case is a bad actor makes your coverage say 0% — but still not ideal.

Better approach is use an environment variable.