search

codedownio / codedown-languages

Language packs for CodeDown (kernels, language servers, package managers, etc.)
1 stars 0 forks source link

GHC 9.8 test hangs (parse error apparently?) #64

Closed thomasjm closed 5 months ago

thomasjm commented 6 months ago

An LSP code actions test is actually passing, but then we hang after sending the shutdown message to the server.

We should add a timeout after which we kill the process to the test harness.

But first, track down this parse error.

thomasjm commented 5 months ago

Aha, it seems the problem is:

  1. The test had finished, and had returned from its session code
  2. The finally handler in lsp-test had started the shutdown process, which caused a shutdown message to be sent
  3. HLS was still doing indexing stuff and sending $/progress, messages during this time, and the auto-responder code in lsp-test was responding to these. This was in violation of the LSP spec, which states that a client won't respond to any requests after the shutdown message is sent. HLS responded to this by crashing.