Fix/add details about the ExtTime structure

codedread / bitjs

Binary Tools for JavaScript

MIT License

81 stars 7 forks source link

Fix/add details about the ExtTime structure #32

Closed andrebrait closed 2 years ago

andrebrait commented 2 years ago

I recently started working on processing this part of RAR files and I used this documentation as a base for it.

I've added an explanation on what the ExtTime consists of and I fixed the pseudo-code. The number of bits to read for each date was wrong (it should be 32, not 16) and I added the detection of the leap second flag.

I also added some data to clarify the date/time format used.

codedread commented 2 years ago

Thank you @andrebrait ! I won't be able to verify this, so I'm basically trusting your hard work 😃

andrebrait commented 2 years ago

@codedread I just wrote and tested that bit on https://github.com/junrar/junrar/pull/76 so I'm pretty sure it's correct 😄