codeeu / coding-events

A Django app for adding EU Code Week events and showing them on a map.
http://events.codeweek.eu
MIT License
17 stars 36 forks source link

Better search #295

Closed sparkica closed 9 years ago

sparkica commented 9 years ago

Finally! :) This will solve issues #256 and #274

Added:

Removed:

In order for pagination to work with faceted search, I added custom endless pagination js file - I just copied original endless_pagination.js, changed all GET requests to POST requests and pass form data. IMHO this was the only sensible option in our case (my opinion based on this stackoverflow answer). @ercchy what do you think? I played around with sessions, but it was causing too many serialization issues. I don't have enough experience with overriding methods from other libraries :)

So... @ercchy can you please take a look at the changes before we deploy?

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.17%) when pulling 8e3ca497c79a64aaff2f573355a5142845c88b57 on sparkica:better_search into 03198a8ef0a5beac7dfc55db715aa9926e9c91b6 on codeeu:master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.11%) when pulling 98994d57bb535de4b5770a5aebbebf53c5c24bc6 on sparkica:better_search into 03198a8ef0a5beac7dfc55db715aa9926e9c91b6 on codeeu:master.

ercchy commented 9 years ago

Good work Mateja the Cat!!!