search

codeeu / coding-events

A Django app for adding EU Code Week events and showing them on a map.
http://events.codeweek.eu
MIT License
17 stars 36 forks source link

Moar better search #304

Closed sparkica closed 9 years ago

sparkica commented 9 years ago

Bugfix for #303: when user clicks on country and/or checks past events, these settings are passed to search form and reflected in search results.

There was a tiny tiny regex bug in function that updates search url on List events button: after user clicked on country button, country name was updated, but country code was not.

Also, I added support for search query string in GET requests that will be used for #112 - displaying tags as searchable urls. The parameter is named 'q' - which is typically used name for query strings.

E.g.: http://127.0.0.1:8000/search/?q=bla+bla

@ercchy Code review... please :)

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.45%) when pulling c4bae8194923314a3504a51de90c269c4a728867 on sparkica:moar_better_search into 7247d18716dae5f2016ad669f8dfaf0acd4c8280 on codeeu:master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+1.76%) when pulling d2e55190d3fcc5ea96c13586eb8e7be8512d2311 on sparkica:moar_better_search into 7247d18716dae5f2016ad669f8dfaf0acd4c8280 on codeeu:master.

sparkica commented 9 years ago

I think @ercchy is a bit busy at the moment... @gandalfar would you please make a code review of this PR, so we can start merging them? Thanks :)