search

codeeu / coding-events

A Django app for adding EU Code Week events and showing them on a map.
http://events.codeweek.eu
MIT License
17 stars 36 forks source link

Problems with markers performance #326

Closed Konviser closed 9 years ago

Konviser commented 9 years ago

When the marker is clicked it takes some time for pop up window to appear. As far as I found out it's due to the click listener on overlapSpiderifier object. It falls into some strange loop and triggers click events multiple times. However if we move the the 'click event' from the loop in the createMarker function to the createMap then it works fine. I've tested it here locally and can send pull request but I just need some comments why the click handler is placed to the createMarker function? @ercchy , for instance? :)

goranche commented 9 years ago

nah, that would probably be a bug introduced by me while changing stuff so the index page reads events using the new REST API

somehow I didn't notice this (haven't looked at it yet)

goranche commented 9 years ago

@Konviser a.k.a. prepare a PR and I'll take a look :wink:

thanks for finding and debugging it :angel:

Konviser commented 9 years ago

:) I've only put a breakpoint inside the click event handler and saw some strange behavior

goranche commented 9 years ago

it's still called debugging :wink:

Konviser commented 9 years ago

ok, I agree :)

goranche commented 9 years ago

good... :smile:

will you fix it (and send a PR), or should I?

Konviser commented 9 years ago

yep. i will

goranche commented 9 years ago

fixed by #327