codeeu / coding-events

A Django app for adding EU Code Week events and showing them on a map.
http://events.codeweek.eu
MIT License
17 stars 36 forks source link

not able to write the end time - datepicker picks current system time #414

Open raffaelj opened 8 years ago

raffaelj commented 8 years ago

I added my events and tried to write/pick the end time of my event. For choosing the start time the popup closed after clicking on the start date and I had to open it again for choosing the correct time. But this is OK.

For choosing the end time the popup closes after picking the day and the time is automatically set to my system time. The workaround was to change the time of my Windows device and then change the event again but this not the best solution...

System: Win7 Pro SP1, FF41.0 with Adblock Plus, NoScript and some developer tools - but all scripts were allowed for codeweek.eu

Also tested with IE11.0.23 - same bug so it shouldnt be a problem with my FF-Plugins

mitio commented 8 years ago

@raffaelj Thanks for reporting this! We'll have a look as soon as possible.

In the meantime, if you can find the issue in the code yourself, please send us a pull request.

ioana-chiorean commented 7 years ago

I am able to reproduce the double opening - one for sate and one for time. It would be nice to check if we can change both in one action.

I am not able to reproduce the end date issues. For me it works liek the start. Please let us know if you still see this error.

raffaelj commented 7 years ago

I can still reproduce a bug. But now it's not my system time. The end time picks the start time after clicking in the input field again. I added some gifs for visualization. (tested with FF 47.0.1, Win7Pro SP1 64bit)

choosing end date first

codeweek-eu-datetime-picker-bug

trying to change end date and time

codeweek-eu-datetime-picker-bug02

trying to choose a different time at the same day

codeweek-eu-datetime-picker-bug03

raffaelj commented 7 years ago

I don't have time for more tests right now, but maybe there is the issue:

value: start_date.val()

https://github.com/codeeu/coding-events/blob/0a3cb24b3daeadc273f9bc8e6b0926fd8ef97c7a/static/js/events.js#L48

end_date.datetimepicker({
            //... some stuff
            onShow: function () {
                this.setOptions({
                    minDate: get_date_range(start_date),
                    value: start_date.val() // looks like choosing start time everytime the popup opens
                });
            }
});
ioana-chiorean commented 7 years ago

@oana-sipos can you look into this ?

oana-sipos commented 7 years ago

Yes, will do, most probably tomorrow.