Fix for the top menu hover shading problem

codeeu / coding-events

A Django app for adding EU Code Week events and showing them on a map.

http://events.codeweek.eu

MIT License

17 stars 36 forks source link

Fix for the top menu hover shading problem #420

Closed ercchy closed 8 years ago

ercchy commented 8 years ago

Hi guys, I was adding an event today and saw two little problems with the design. I am sending fixes for them.

In the page submenu, there is a problem on hover, where shading does not meet the height of the menu. europe code week map of events

The other error is that modal window on the login page overflows the main menu. europe code week login

I have also added a fix for the scoreboard rendering, which is also overflowing the menu. europe code week events scoreboard

Thanks, Erika

mitio commented 8 years ago

@sparkica @ercchy Is this ready for merging? I see the in progress label applied?

As a side note, thanks for the UI fixes! I'd like to merge them :)

ercchy commented 8 years ago

As far as I am concerned it is ready, I am not exactly sure why the in progress label was added. Maybe it was by accident @sparkica?

mitio commented 8 years ago

I also think it's good. Merging! Thank you @ercchy!

mitio commented 8 years ago

As a side note, in the future, when you send a new pull request, it's a good idea to make it from a feature branch. Also, it's better to rebase your feature branch on master, rather than merging master into the feature branch.