Fix indentation and add status=="Approved" to event filter

[michelesr]

Also disabled a unit test that check scoreboard content, given that now scoreboard is filtered to countries with at least 1 event and without events inserted in the testdb is blank

[michelesr]

Commands used to fix indentation:

# replace tabs with 4 spaces
find . -name '*.py' -exec sed -i 's/\t/    /g' {} \;
# remove trailing backspaces
find . -name '*.py' -exec sed -i 's/ *$//g' {} \;

[michelesr]

ping @mitio

[michelesr]

Fix #421

[mitio]

@michelesr I think this sed pattern can potentially do harm to some files as it replaces tabs in any place in the line, not only at the start. Maybe we should instead anchor it to the beginning of the line?

Also, how about we add \t to the one for removing trailing spaces as well? Might have some trailing tabs here and there.

Another point--why didn't you separate the whitespace changes from the other ones? I think it's a better idea (by using feature branches).

Are you going to change the patterns or should I do the replacement?

[michelesr]

@michelesr I think this sed pattern can potentially do harm to some files as it replaces tabs in any place in the line, not only at the start. Maybe we should instead anchor it to the beginning of the line?

Appending the regex for the beginning of the line will not remove multiple tab i guess, and even if you use the + wildcard you can't know how many spaces to apply ...

Also, how about we add \t to the one for removing trailing spaces as well? Might have some trailing tabs here and there.

If the command to replace tabs with spaces is performed well, then tabs are replaced with spaces and trailing spaces are removed with the next command

Another point--why didn't you separate the whitespace changes from the other ones? I think it's a better idea (by using feature branches).

That's a good point, i was thinking to split in two commits (one for the indentation, and one for the filter hotfix)

[michelesr]

@mitio: if you got ideas for sed pattern post here and i'll give a check

[mitio]

@michelesr I think this sed pattern can potentially do harm to some files as it replaces tabs in any place in the line, not only at the start. Maybe we should instead anchor it to the beginning of the line?

Appending the regex for the beginning of the line will not remove multiple tab i guess, and even if you use the + wildcard you can't know how many spaces to apply ...

Agreed about the count of replacements.

How about we use autopep8 or this script instead?

Also, how about we add \t to the one for removing trailing spaces as well? Might have some trailing tabs here and there.

If the command to replace tabs with spaces is performed well, then tabs are replaced with spaces and trailing spaces are removed with the next command

If we're removing only indentation spaces, tabs can still be left at the end of the line.

[michelesr]

Ok... then let's try with the autopep8 and remotion of trailing spaces and tabs.

Working on it.

[michelesr]

Closing this PR... i'll make another with cleaner commits

[mitio]

:+1: