codefog / contao-events_subscriptions

Contao extension that allows members of your website to subscribe to the events
MIT License
10 stars 5 forks source link

Enhancement: Add subscribers via backend: suggest online active members #63

Closed Kahmoon closed 3 years ago

Kahmoon commented 3 years ago

Hi Kamil,

actually when i add subscribers via backend it also shows members which are deactivated long time ago. Its kinda risky to klick the wrong one and send a mail to an inactive student.

Members which are not active and not active anymore (deactivation date) should not be shown in this list. This would be a great enhancement for every user of this extension and probably a small change :-)

Greetings

qzminski commented 3 years ago

If they are no longer active, maybe they should just be deleted from the database?

Kahmoon commented 3 years ago

Nah, that would not be a good solution because they can be reactivated if they book other lessons. Also we use this data for history.

qzminski commented 3 years ago

How about this compromise? I don't want to take away a possibility of subscribing inactive members completely.

2021-06-01 at 19 13

Kahmoon commented 3 years ago

Hmm i´m fine with that. But does it make sense to subscribe inactive users? The only reason i see is for future events where account is not activated yet.

So let´s do it this way. Main thing is to split them to not accidently add old/inactive members with similarly names.

qzminski commented 3 years ago

We treat a member as inactive even his account is "active", but the logging in is turned off. I can imagine a use case where somebody uses members to just manage their data without giving them option to log into the frontend. That's why I would like to keep the split into active and inactive members.

The only reason i see is for future events where account is not activated yet.

That is also a vital reason IMO.

Kahmoon commented 3 years ago

Can you set active first. Actually it shows inactive first Bildschirmfoto 2021-06-02 um 14 48 30

qzminski commented 3 years ago

Good point, just improved that.

Kahmoon commented 3 years ago

Can you set the css class on inactive elements (e.g. inactive-result) differently then active entries (active-result)?

This would make a BE css styling possible. For example lighter text color

qzminski commented 3 years ago

No, as far as I know it's not possible.