http_build_query wrong arguments seperator

codefog / contao-haste

Haste is a collection of tools and classes to ease working with Contao

http://codefog.pl/extension/haste.html

MIT License

43 stars 24 forks source link

Closed koertho closed 6 years ago

koertho commented 6 years ago

Some Hoster (for example Host Europe) returning a wrong default argument seperator for http_build_query function. So please change the function call from http_build_query(array_merge($queries, $new)); to http_build_query(array_merge($queries, $new),'', '&');. For example here: https://github.com/codefog/contao-haste/blob/966cd2e4cbf3236cef868ee67aff394188eedf5e/library/Haste/Util/Url.php#L43

qzminski commented 6 years ago

That's interesting, thanks for reporting.

Toflar commented 6 years ago

You should always pass it, I've stumbled over similar stuff, very annoying :)

qzminski commented 6 years ago

Fixed in 1475f7a.

koertho commented 6 years ago

That was quick, thanks!