search

codefog / contao-haste

Haste is a collection of tools and classes to ease working with Contao
http://codefog.pl/extension/haste.html
MIT License
43 stars 24 forks source link

Contao\FileUpload::getMaximumUploadSize() is static in Contao 4.6 #135

Closed markocupic closed 5 years ago

markocupic commented 5 years ago

[2018-10-15 14:02:08] request.CRITICAL: Uncaught PHP Exception Symfony\Component\Debug\Exception\FatalErrorException: "Compile Error: Cannot make static method Contao\FileUpload::getMaximumUploadSize() non static in class Haste\Util\FileUpload" at /home/sacpilat/public_html/pilot2018/vendor/codefog/contao-haste/library/Haste/Util/FileUpload.php line 5 {"exception":"[object] (Symfony\Component\Debug\Exception\FatalErrorException(code: 0): Compile Error: Cannot make static method Contao\FileUpload::getMaximumUploadSize() non static in class Haste\Util\FileUpload at /home/sacpilat/public_html/pilot2018/vendor/codefog/contao-haste/library/Haste/Util/FileUpload.php:5)"} []

qzminski commented 5 years ago

Looks like a Contao BC break? @aschempp @Toflar

https://github.com/contao/core-bundle/blame/master/src/Resources/contao/classes/FileUpload.php#L261

Toflar commented 5 years ago

/cc @ausi @leofeyer

ausi commented 5 years ago

Yes. I think we have to revert the change to the method signature from https://github.com/contao/core-bundle/commit/f53e59e7e13adbac97f183ebb35a93cc9b84da72#diff-baa21854e252dcb04da2c161f324cf07L255

@leofeyer should I create a PR?

leofeyer commented 5 years ago

Yes please. 😊

ausi commented 5 years ago

Done: contao/contao#188