search

codefog / contao-haste

Haste is a collection of tools and classes to ease working with Contao
http://codefog.pl/extension/haste.html
MIT License
43 stars 24 forks source link

Add support for phpoffice/phpspreadsheet #137

Closed qzminski closed 5 years ago

qzminski commented 5 years ago

The phpoffice/phpexcel is deprecated for a looong time already.

Toflar commented 5 years ago

Nice! I think we should remove the deprecated stuff from the docs and the suggests. In the code we might want to make it work but trigger a user deprecation using trigger_error().

aschempp commented 5 years ago

Totally agree with @Toflar

Also, instead of testing for class_exists multiple times, maybe we should use instanceof on $this->spreadsheet?

qzminski commented 5 years ago

Updated in b68d234. Shall I merge it then?