codefog / contao-haste

Haste is a collection of tools and classes to ease working with Contao
http://codefog.pl/extension/haste.html
MIT License
43 stars 24 forks source link

Incorrect parameter count in the call to native function 'FIND_IN_SET' #193

Closed argus231 closed 1 year ago

argus231 commented 1 year ago

vendor/codefog/contao-haste/src/Model/DcaRelationsModel.php

152&127 -> $order = ' ORDER BY FIND_IN_SET('.$connection->quoteIdentifier($relation['reference_field']).', '.implode(',', $recordValues).')';

wrong -> ORDER BY FIND_IN_SET(xxx, 125,18,279,5785,50730) correct -> ORDER BY FIND_IN_SET(xxx, "125,18,279,5785,50730")

qzminski commented 1 year ago

@argus231 could you test and confirm if https://github.com/codefog/contao-haste/commit/f3a693757fcbd54b4f82a176a80f99d15b81e77d solves the problem?

argus231 commented 1 year ago

@qzminski that would fix the problem.

qzminski commented 1 year ago

Thanks for testing, I have just released 5.0.12.