search

codefog / contao-haste

Haste is a collection of tools and classes to ease working with Contao
http://codefog.pl/extension/haste.html
MIT License
43 stars 24 forks source link

4.X | Image:addWatermark() fails in PHP8 #194

Closed cboelter closed 1 year ago

cboelter commented 1 year ago

I'm currently working on an isotope shop which is using the watermark feature. This feature relies on the haste Image::addWatermark() function. In Line 123 it contains a check that $resWatermark is a resource. Since PHP8 the $resWatermark could also be an instance of GDImage. Is it possible to be fixed in the haste 4.X?

aschempp commented 1 year ago

I'm sure if you do a pull request we can merge it 😊

aschempp commented 1 year ago

fixed in 2388687f9d14fad01cbf57a6b50eb519d44fcb63