search

codefog / contao-haste

Haste is a collection of tools and classes to ease working with Contao
http://codefog.pl/extension/haste.html
MIT License
43 stars 24 forks source link

do only log if enableVersioning is true #85

Closed fiedsch closed 8 years ago

fiedsch commented 8 years ago

Versions->initialize() and ->create() have the check built in, but the call to System::log() is unconditional. So a log entry will always be generated.

aschempp commented 8 years ago

Shouldn't the logging just be done in the Version class?

fiedsch commented 8 years ago

Sure. Version does log what it is doing. I don't know what the intention of the additional call to System::log() was in the first place and did not question that. Maybe it is for historical reasons? I.e. did Version always log or was that introduced later?

qzminski commented 8 years ago

Merged in 06bc27d.