search

codefog / contao-news_categories

Extend the Contao news module with categories
MIT License
32 stars 25 forks source link

Support for Contao 5.1+ #241

Closed aschempp closed 10 months ago

aschempp commented 1 year ago

This should update the extension for Contao 5.1 support (only). I initially tried to keep Contao 4.13 compatibility, but that's almost impossible with the new feed page types and a lot of compatibility breaks. Not sure if this would be a new major version since we dropped several classes. They are not really API, but it also wouldn't harm (maybe we could refactor some more stuff).

PS: still a draft since it's all brain dump and not fully tested yet (especially the feed stuff).

jankout commented 1 year ago

That’s amazing and thank you very much for your great work, @aschempp

how and when will it be published? @qzminski

aschempp commented 1 year ago

when its ready… 🤷 https://www.terminal42.ch/en/open-source

aschempp commented 1 year ago

I just noticed removing the picker widget might mean this would be a new major version. Which means I could remove some dead code and deprecations. What do you think @qzminski, should we have a new major or re-add the widget?

qzminski commented 1 year ago

Have a new major definitely 😄

aschempp commented 1 year ago

very well then 🙃 I removed the deprecated stuff and updated everything to using autowiring and attributes 😎

aschempp commented 1 year ago

I think this is ready for release (RC or stable). I even added a new CI chain (see https://github.com/aschempp/contao-news_categories/actions) 😎

qzminski commented 10 months ago

Released as 4.0.0. Thanks a lot @aschempp !

jankout commented 10 months ago

Thank you very much @aschempp for your great work.