search

codefog / contao-news_categories

Extend the Contao news module with categories
MIT License
32 stars 25 forks source link

4.0.8: NewsListener::onNewsListCountItems(): Return value must be of type int, false returned #272

Closed janborg closed 1 month ago

janborg commented 1 month ago

Since updating codefog/contao-news_categories to 4.0.8, I get the following error. Contao 5.3.15

As workaround, I added a conflict for this version in my composer.json

Codefog\NewsCategoriesBundle\EventListener\NewsListener::onNewsListCountItems(): Return value must be of type int, false returned

TypeError:
Codefog\NewsCategoriesBundle\EventListener\NewsListener::onNewsListCountItems(): Return value must be of type int, false returned

  at vendor/codefog/contao-news_categories/src/EventListener/NewsListener.php:39
  at Codefog\NewsCategoriesBundle\EventListener\NewsListener->onNewsListCountItems()
     (vendor/contao/news-bundle/contao/modules/ModuleNewsList.php:178)
  at Contao\ModuleNewsList->countItems()
     (vendor/contao/news-bundle/contao/modules/ModuleNewsList.php:108)
  at Contao\ModuleNewsList->compile()
     (vendor/contao/core-bundle/contao/modules/Module.php:213)
  at Contao\Module->generate()
     (vendor/contao/news-bundle/contao/modules/ModuleNewsList.php:73)
  at Contao\ModuleNewsList->generate()
     (vendor/codefog/contao-news_categories/src/FrontendModule/NewsListModule.php:52)
  at Codefog\NewsCategoriesBundle\FrontendModule\NewsListModule->generate()
     (vendor/contao/core-bundle/contao/library/Contao/Controller.php:405)
  at Contao\Controller::getFrontendModule()
     (vendor/contao/core-bundle/contao/elements/ContentModule.php:59)
  at Contao\ContentModule->generate()
     (vendor/contao/core-bundle/contao/library/Contao/Controller.php:601)
  at Contao\Controller::getContentElement()
     (vendor/contao/core-bundle/contao/modules/ModuleArticle.php:189)
  at Contao\ModuleArticle->compile()
     (vendor/contao/core-bundle/contao/modules/Module.php:213)
  at Contao\Module->generate()
     (vendor/contao/core-bundle/contao/modules/ModuleArticle.php:69)
  at Contao\ModuleArticle->generate()
     (vendor/contao/core-bundle/contao/library/Contao/Controller.php:490)
  at Contao\Controller::getArticle()
     (vendor/contao/core-bundle/contao/library/Contao/Controller.php:356)
  at Contao\Controller::getFrontendModule()
     (vendor/contao/core-bundle/contao/pages/PageRegular.php:177)
  at Contao\PageRegular->prepare()
     (vendor/contao/core-bundle/contao/pages/PageRegular.php:47)
  at Contao\PageRegular->getResponse()
     (vendor/contao/core-bundle/contao/controllers/FrontendIndex.php:65)
  at Contao\FrontendIndex->renderPage()
     (vendor/symfony/http-kernel/HttpKernel.php:181)
  at Symfony\Component\HttpKernel\HttpKernel->handleRaw()
     (vendor/symfony/http-kernel/HttpKernel.php:76)
  at Symfony\Component\HttpKernel\HttpKernel->handle()
     (vendor/symfony/http-kernel/Kernel.php:197)
  at Symfony\Component\HttpKernel\Kernel->handle()
     (public/index.php:42)
qzminski commented 1 month ago

This is because of the https://github.com/codefog/contao-news_categories/pull/263 pull request. I have reverted the changes in 4.0.9.