Missing humanitarian sector codes

codeforIATI / IATI-Stats

Python application for generating JSON stats files from IATI data

https://stats.codeforiati.org

Other

0 stars 1 forks source link

Missing humanitarian sector codes #23

Closed markbrough closed 2 years ago

markbrough commented 2 years ago

Humanitarian codes 72011 and 72012 are missing and not being used to calculate humanitarian activities

andylolz commented 2 years ago

Good spot – and thanks for the PR @markbrough!

Just trying to figure out what went wrong here…

Looks like these codes were added in https://github.com/codeforIATI/IATI-Codelists-NonEmbedded/pull/52, which predates this fork. The source repo has the same bug, so I guess that’s why I missed this.

Still, I wonder if there’s a better way to solve this than having a hardcoded list of humanitarian codes? Seems like we could easily forget to update this in the future…

markbrough commented 2 years ago

Hmm this is a good question. Perhaps we could assume that any codes matching the pattern 72xxx, 73xxx or 74xxx are humanitarian?