search

codeforIATI / IATI-Stats

Python application for generating JSON stats files from IATI data
https://stats.codeforiati.org
Other
0 stars 1 forks source link

GitHub actions deploy happens for all branches #25

Closed Bjwebb closed 2 years ago

Bjwebb commented 2 years ago

Deploy to IATI-Stats-Public gh-pages branch happens for any branch pushed to this repository. This would include branches that aren't ready to go live yet.

https://github.com/codeforIATI/IATI-Stats/blob/d32487f3e51673b09e6e6127848b6164b8b030e7/.github/workflows/run.yml#L74-L83

andylolz commented 2 years ago

Yeah, that’s a good point. Analytics does the right thing, but this repo doesn’t.

andylolz commented 2 years ago

Should hopefully be fixed now (by never building on push).

andylolz commented 2 years ago

If it’s useful @Bjwebb we could set up codeforIATI/IATI-Stats-dev – equivalent to codeforIATI/analytics-dev. Then create a dev branch, and make it build to there.

I haven’t had a use for that yet, but it probably makes sense for it to exist.

Bjwebb commented 2 years ago

Yes, that would be useful for my current work, for which I need to test how much longer the stats run takes.

andylolz commented 2 years ago

Okay cool, *hopefully* that should be sorted via ed894d0c49cad0d8d40b49933ca0877eb32a21f1…

So if you push to dev, it should build to https://github.com/codeforIATI/IATI-Stats-dev

andylolz commented 2 years ago

Oh, boring – I did it a bit wrong https://github.com/codeforIATI/IATI-Stats/actions/runs/3095964959/jobs/5010962980

Bjwebb commented 2 years ago

I had a go at disabling gitaggregate to see if everything else works.

andylolz commented 2 years ago

Cool cool, sounds good.

Bjwebb commented 2 years ago

Yes, it works. Thanks for setting this up.