search

codeforIATI / iati-datastore

An open-source datastore for IATI data with RESTful web API providing XML, JSON, CSV plus ETL tools
https://datastore.codeforiati.org
Other
1 stars 1 forks source link

Multi currency export - choices / parameters (for csv files) #372

Open stevieflow opened 2 years ago

stevieflow commented 2 years ago

Following on from https://github.com/codeforIATI/iati-datastore/issues/335 it would be good to detail what we expect when we have multiple currencies in storage

On the CSV output we can request:

one activity per-row

one transaction per-row

one budget per-row

As we store more currencies (starting with USD) via https://github.com/codeforIATI/iati-datastore/issues/335 - are we thinking these would be bundled in the csv files as extra columns (in which case, we should be clear on the naming of them), and/or could/should this be something the user could request in the query, and therefore only receive that currency (which will need some clearer specification)

I assume the same would apply for xlsx files

Over to @markbrough initially

markbrough commented 2 years ago

So I think we should add the following columns:

one activity per-row

one transaction per-row

one budget per-row

And while we are here please let's also fix #371

I like the idea of being able to request the returned currency, so that you don't get all these additional columns, but think it might be simple to just do this for now? Wdyt @stevieflow / @radix0000 / others?

stevieflow commented 2 years ago

Thanks @markbrough

should add

Yes, I think building the template to include all the existing and new columns would be useful regardless. We can then look into any functionality to filter / limit the output

@radix0000 over to you!

radix0000 commented 2 years ago

Okay, will take a look at adding those csv columns.