codeforIATI / iati-tables

https://iati-tables.codeforiati.org
MIT License
1 stars 0 forks source link

Add linting #22

Closed tillywoodfield closed 5 months ago

tillywoodfield commented 5 months ago
Bjwebb commented 5 months ago

BTW, it's preferable to set a different author for the black reformatting, so that your name isn't next to many lines in git blame. Here's an example from another repo https://github.com/OpenDataServices/flatten-tool/commit/a094fea22d143c150e9cb918b2cb24e964de844c

tillywoodfield commented 5 months ago

BTW, it's preferable to set a different author for the black reformatting, so that your name isn't next to many lines in git blame. Here's an example from another repo OpenDataServices/flatten-tool@a094fea

@Bjwebb that makes sense, thank you, I've updated the first commit to use that author

odscjames commented 5 months ago

flake8 iatidata/

Extremely pedantically, we have this in the github actions (using paths with all the lint tools) which is great but can it be in the readme too? Otherwise sometimes peoples virtual environments get processed too which takes a while and gives many false alerts. We can do that in another PR tho.

tillywoodfield commented 5 months ago

flake8 iatidata/

Extremely pedantically, we have this in the github actions (using paths with all the lint tools) which is great but can it be in the readme too? Otherwise sometimes peoples virtual environments get processed too which takes a while and gives many false alerts. We can do that in another PR tho.

@odscjames Please could you clarify, I had this in the readme, do you want me to add something else?

odscjames commented 5 months ago

You totally did, I apologise! Not sure how I got that wrong.