search

codeforUV / food_resources

A project that aims to increase food access for residents of the Upper Valley region of VT/NH
https://food-resources.herokuapp.com
MIT License
1 stars 6 forks source link

Set up rspec #68

Closed siobhanjacobson closed 3 years ago

siobhanjacobson commented 3 years ago

I'll probably start with model tests.

siobhanjacobson commented 3 years ago

@thomascchen I think factory_bot and shoulda-matchers would also be very useful. Is it okay if I add those gems as well?

siobhanjacobson commented 3 years ago

I'm running into issues with Ruby and Rails being too new for rspec. I think we can make it work if we use the development branch. https://stackoverflow.com/a/65895657

thomascchen commented 3 years ago

Hmm I'm using RSpec with Rails 6.1 on another app with Ruby 2.7.2. I wonder if it's Ruby 3 that's the problem, although that would surprise me...

thomascchen commented 3 years ago

Oh I read the issue now... we could try that branch. I'd also be okay with trying out minitest. I've always used RSpec but maybe minitest is fine too?

siobhanjacobson commented 3 years ago

I'm running into issues with other dependencies when trying to use the branch in the following PR. Hopefully it'll be merged in soon (the latest discussion was only 4 days ago). https://github.com/rspec/rspec-rails/pull/2398

siobhanjacobson commented 3 years ago

If not, I'll switch gears and try minitest out.

siobhanjacobson commented 3 years ago

Edit -- I misread the latest comment in the rspec PR. It hasn't been released yet.