handle missing social accounts for people

[techieshark]

• Not all people will have Facebook/Twitter pages.
• Instead of trying to render a non-existing page/tweets,
• Before this, we tried to render things that didn't exist
• Now we just tell the user that the person they’re interested in has no Facebook or Twitter page, as the case may be.
• This fixes #51 (note that it keeps the tab for a consistent UI, but otherwise handles the situation more gracefully than previously).

[tbuckl]

this works for facebook. but not for twitter. for city manager, shows MesaDistrict6 account?

[tbuckl]

ok i can merge this because it seems to work for facebook. and then the most recent PR for social media (#63) seems to work for twitter. but maybe it makes sense to close both of the social PR's, merge them, and submit them together?

[techieshark]

let me double check this before you do anything else on it. thanks.

[techieshark]

It is maybe a bit tricky to verify this, but the idea is that if social is set to [] in the council-info/people.js, then this.socialDetails('twitter') on person.js:65 (https://github.com/codeforamerica/MuniciPal/blob/c40d3664e55b949c65d08544970c54d2f6228c7d/app/assets/javascripts/person.js#L65) will return null / false and line 68 will be triggered which renders the 'noTwitterTemplate'.

The reason you don't see it right now is because the Manager actually has a social entry in the council-info repo.

If you wanted to try it out, you could either remove the twitter object from this line: https://github.com/techieshark/council-info/blob/gh-pages/people.js#L186

or you could set a breakpoint at person.js:65 (before if(this.socialDetails('twitter')) is called, and in the console run this.person.social = [] to fake having no twitter values and then run it from there and you'll see the correct output under the twitter tab.

[tbuckl]

peter, is this up for review still? seems like production on heroku has this fix?

[techieshark]

Check out the manager page on production now. This commit makes it so his social account is missing and you can see the result on production and compare to the result proposed in this branch.

[tbuckl]

ah ok, thanks. so this works for the city manager but then i get this for the mayor:

[techieshark]

@buckleytom that's fine, the problem you mention there is a separate issue that was fixed in master already by this commit: https://github.com/codeforamerica/MuniciPal/commit/6aa9f4fc43aaab664cb3d7f35daa6d2efed5f0f1

If you want to see this working locally, try this:

git checkout master
git pull
git checkout -b master-merge-test
git merge  frontend/handle-missing-social-accounts
rails s

That will have the fix for the missing social media account from this commit, plus the fix for the missing widget already in master that I mentioned, and you should see the Mayor's twitter widget as well as the message on the City Manager's page about his missing account.