search

codeforamerica / adopt-a-hydrant

A web application that allows citizens to "adopt" civic infrastructure, such as fire hydrants that need to be shoveled out after it snows.
http://adopt-a-hydrant.herokuapp.com/
BSD 3-Clause "New" or "Revised" License
713 stars 233 forks source link

Help #11

Closed ahcarpenter closed 12 years ago

sferik commented 12 years ago

There are a large number of files where the only difference appears to be the addition or removal of whitespace. Can you please exclude these changes from your pull request?

sferik commented 12 years ago

Rather than making me review every line of code in your pull request to understand what it's doing, it would be helpful if you used the space afforded by commit messages and the pull request description to explain what changes you have made, why you have made them, and if there are any areas that require attention.

For example, here is model pull request I received yesterday: sferik/t#51.

sferik commented 12 years ago

Pull requests should be sent around discrete features or bug fixes. This branch seems to contain a mishmash of unrelated things. This makes it much more complex and harder to pull.