search

codeforamerica / balance

A text message system for checking one's EBT card balance (SNAP benefits and more)
MIT License
47 stars 37 forks source link

Include correct # of digits in error message #186

Closed lippytak closed 10 years ago

lippytak commented 10 years ago

A user emailed me because she had texted in a 16 digit number to the Texas phone # even though Texas EBT numbers are 19 digits. We could improve this by fixing outreach materials/splash pages (https://github.com/codeforamerica/splash/issues/15) and by improving the error messages for this case.

In particular, the error message she got (sorry_try_again in the message generator): Sorry, that EBT number doesn't look right. Please try again.

Let's consider breaking out a specific 'wrong number of digits' error message that specifies the correct number of digits for the state.

Related to https://github.com/codeforamerica/balance/issues/173

daguar commented 10 years ago

Love it! We will also need Spanish translation, or I can hack it.

lippytak commented 10 years ago

@daguar HISI

daguar commented 10 years ago

I've implemented this in English on PR #188.

I recommend we run lean and ship this now rather than waiting for other languages to be implemented (we can add this for those when they come in). Sound good @lippytak?

daguar commented 10 years ago

Tested successfully on dev server with both 16-digit and 19-digit states.

lippytak commented 10 years ago

Ship it.

Take a minute to add the new phrases to our translation spreadsheet just so we don't lose track.

daguar commented 10 years ago

Thanks for the reminder! I've added the new phrase and I've also added a notes column for tracking stuff like this.

screen shot 2014-10-24 at 9 40 16 am

I'm closing this and opening a new issue for implementing this in other languages.