search

codeforamerica / balance

A text message system for checking one's EBT card balance (SNAP benefits and more)
MIT License
47 stars 37 forks source link

Prevent infinite loops #244

Closed lippytak closed 9 years ago

lippytak commented 9 years ago

BLUF: A user put our Balance phone # into the welcome/splash page (splash.codeforamerica.org/balance/english/ca/), which triggered an infinitely apologetic loop: screen shot 2014-12-14 at 7 00 59 pm

And it used a lot of budget: screen shot 2014-12-14 at 6 59 00 pm

As far as we can tell users weren't affected.

@alanjosephwilliams and I concocted a pretty thorough food stamp mafia story before diagnosing this, but that's for another time...

lippytak commented 9 years ago

@daguar can you imagine a scenario where we would want to send messages from one balance-production phone # to another? If not the easiest/cleanest solution might be to block all outgoing messages to numbers in the same account. Don’t have strong opinions just thought this may be easier and then we wouldn’t have to worry about message content changing.

daguar commented 9 years ago

I cannot. Let's discuss in 10 mins when I'm in. There's one yak I wanna gut check with you and then I think this approach is good to go.

On Dec 19, 2014, at 11:10 AM, Jake Solomon notifications@github.com wrote:

@daguar can you imagine a scenario where we would want to send messages from one balance-production phone # to another? If not the easiest/cleanest solution might be to block all outgoing messages to numbers in the same account. Don’t have strong opinions just thought this may be easier and then we wouldn’t have to worry about message content changing.

— Reply to this email directly or view it on GitHub.