search

codeforamerica / bestnest-app

http://dev.bestnestapp.com
6 stars 2 forks source link

issues #3 and #9 addressed #10

Closed jeremiak closed 10 years ago

jeremiak commented 10 years ago

cleaned up the project structure and essentially started over. removed pngs and started a new on the css and html structure

junosuarez commented 10 years ago

LGTM (looks good to me). Are you planning on writing straight CSS or using any sort of preprocessor like SASS? Unless you have any outstanding questions that you specifically wanted feedback on, I'd say go ahead and merge it.

jeremiak commented 10 years ago

Definitely would like to use a pre-processor, likely SASS. I can introduce that in a different branch/issue - will merge. Is there a preferred workflow for accepting pull requests or should I just use a different branch and then merge in my features as they get done? I'm open to either but haven't really used a specific workflow.