search

codeforamerica / bestnest-app

http://dev.bestnestapp.com
6 stars 2 forks source link

Live reviews for #80 #85

Closed jeremiak closed 10 years ago

jeremiak commented 10 years ago

This pull request should handle showing live reviews content delivered via the API at :homeId/reviews

It should also display the first review (if there is one) on the summary view.

Things that are undefined and therefore likely to change: The state of the summary view if there are no reviews (current like this: http://up.jeremiak.com/X0ku) The display of the reviews view if there are no reviews (currently like this: http://up.jeremiak.com/X0GX)

This PR has nothing to do creating reviews, that will be taken care of in #76

junosuarez commented 10 years ago

This is the stage in the front end app where it probably makes sense to have a separate model layer. Currently, the control flow is such that the view is requesting data directly from the api. This is not actually what we want - we want view rendering to be driven by a model which is backed by the api. For example, if two different views are showing reviews for the same property, we want those to be coming from the model for that property and populated by a single api request.

This will also help with #84.

I'm happy to take on some of this refactoring - let me know if you'd like to as well.

jeremiak commented 10 years ago

That makes sense, would you be able to take on some of this refactoring and then I can take a look at what you did?

jeremiak commented 10 years ago

We're thinking about trying out ReactJS to solve the issue above, but in order to stay on our self-assigned deadlines (see the milestones in this repo) we're going to merge these and deal with the separation of view/model/API in the next sprint likely to help tackle #60 & #84