codeforamerica / bestnest-app

http://dev.bestnestapp.com
6 stars 2 forks source link

User content persist - fixes 82 #97

Closed junosuarez closed 10 years ago

junosuarez commented 10 years ago

see #82

jeremiak commented 10 years ago

Looks good to me, only weird thing is that there is no indicator for a pressed state on those question buttons. Perhaps we could also use the waiting .button CSS definition to also apply to these buttons as they are selected? I'll try it out and push a commit with an idea

jeremiak commented 10 years ago

@jden not sure if you want to take a look since I made a few changes. They were

  1. Removing an extra '/' that was preventing the submission of user content
  2. Added a button.selected css definition and applied it when the button is clicked. It also, clumsily, removes all of the selected class from any sibling <button> elements
junosuarez commented 10 years ago

LGTM. Also, the way you did the class selection isn't clumsy :)