search

codeforamerica / bizfriendly-web

An experiment in digital literacy lessons. The experiment is now over.
http://bizfriend.ly
22 stars 67 forks source link

Alphabetize skills on learn page #156

Closed louh closed 10 years ago

louh commented 10 years ago

See https://github.com/codeforamerica/bizfriendly-web/issues/110

Categories (skills) are alphabetized with a sort function. Details at MDN.

Also, determining what column a skill should be listed in based on its index in the array was unreliable, because there are unpublished skills in it and that created holes in the column. I fixed this by creating an array of only published skills first.

louh commented 10 years ago

re: latest commit, sorting columns vertically by alphabet first, rather than horizontally first, was necessary to keep the list alphabetized on a mobile layout. It could also help with legibility on the desktop layout, since people tend to read lists up and down first.

ondrae commented 10 years ago

This is great Lou, works perfect. I'll merge these in during our next release.

@arielkennan Check out http://staging.bizfriend.ly/learn.html and let us know what you think. Should I add a promoted skill flag, to be able to jump Promote Your Business Online to the top?

arielkennan commented 10 years ago

Looks great! Love the promoted skill flag idea.