search

codeforamerica / bizfriendly-web

An experiment in digital literacy lessons. The experiment is now over.
http://bizfriend.ly
22 stars 67 forks source link

Remove some time precision to fix Date.parse issue in IE9 #183

Closed kborchers closed 9 years ago

kborchers commented 9 years ago

Closes gh-172

ondrae commented 9 years ago

Fantastic. I'm on the road til next week and will check this out then. Thanks!

ondrae commented 9 years ago

Thanks @kborchers, it works.

How did you know that you needed to trim the decimals for time comparison to work in ie9?

How did you find this issue anyways?

kborchers commented 9 years ago

I traced the issue to Date.parse returning NaN so read the Date docs for IE and saw they expected that specific precision.

As for how I found the issue, I was just looking at the Code for America site and that issue happened to pop up as needing help so I jumped on it. After taking over as ED of the jQuery Foundation I don't get to write code much anymore so I've been looking for little places here and there to throw my JS skills at projects that need help.

ondrae commented 9 years ago

Hi @kborchers thanks again for the help.

I'm writing a blog post to announce the Civic Tech Issue Finder. Can I use your quote above in the post?

kborchers commented 9 years ago

Sure, no problem. A link once it's up would be great.

ondrae commented 9 years ago

Its done http://www.codeforamerica.org/blog/2014/10/30/the-civic-tech-issue-finder/ Let me know if you have any edits. Thanks again.

We just hit 2500 clicks on different civic tech issues. Its working!