codeforamerica / brigade-alpha

The old Code for America Brigade website. The new site at https://github.com/codeforamerica/brigade
BSD 3-Clause "New" or "Revised" License
16 stars 18 forks source link

Fix unicode handling against API. #52

Closed migurski closed 9 years ago

migurski commented 10 years ago

Map links do not set correct URLs for organization names with unicode content.

Steps to reproduce:

  1. Visit http://www.codeforamerica.org/brigade/index/Code-for-Warsaw
  2. Pan to the west and slightly south, to the city of Łódź, click the marker.
  3. The URL incorrectly changes to http://www.codeforamerica.org/brigade/index/Code-for-%25C5%2581%25C3%25B3d%25C5%25BA instead of http://www.codeforamerica.org/brigade/index/Code-for-%25C5%2581%25C3%25B3d%25C5%25BA

Related behavior:

  1. Visit http://www.codeforamerica.org/brigade/index/Code-for-Łódź
  2. Note that brigade info panel is correct, but map does not navigate to Poland.

Note that these both work:

Also, http://www.codeforamerica.org/brigade/index/Code-for-%C5%81%C3%B3d%C5%BA should be a synonym for http://www.codeforamerica.org/brigade/index/Code-for-Łódź

Tested in Safari 7, Chrome 32, and Firefox 27.

ondrae commented 9 years ago

Fixed in the CfAPI a while ago.