search

codeforamerica / chime

A city-focused content management system
http://chimecms.org/
BSD 3-Clause "New" or "Revised" License
35 stars 12 forks source link

Respond with 404 for non-existent files in preview. #458

Closed migurski closed 9 years ago

migurski commented 9 years ago

Sample error when requesting a missing file, e.g. http://127.0.0.1:5000/tree/ptqlkjzzl/view/categories/missing.jpg:

Traceback (most recent call last):
  File "/Users/migurski/Sites/Bizarro-CMS/chime/view_functions.py", line 452, in decorated_function
    return route_function(*args, **kwargs)
  File "/Users/migurski/Sites/Bizarro-CMS/chime/view_functions.py", line 505, in decorated_function
    return route_function(*args, **kwargs)
  File "/Users/migurski/Sites/Bizarro-CMS/chime/view_functions.py", line 584, in decorated_function
    return route_function(*args, **kwargs)
  File "/Users/migurski/Sites/Bizarro-CMS/chime/views.py", line 263, in branch_view
    abort(500)
  File "/Users/migurski/Sites/Bizarro-CMS/venv-chimecms/lib/python2.7/site-packages/werkzeug/exceptions.py", line 605, in __call__
    raise self.mapping[code](*args, **kwargs)
InternalServerError: 500: Internal Server Error

Replaces #231.