Resolve GitPython stderr line count

codeforamerica / chime

A city-focused content management system

http://chimecms.org/

BSD 3-Clause "New" or "Revised" License

35 stars 12 forks source link

Resolve GitPython stderr line count #481

Closed migurski closed 9 years ago

migurski commented 9 years ago

Upgraded GitPython to 1.0.1, made a few UTF-8 encoding changes throughout. GitPython #325 suggests this might be enough. App and Process tests passed locally.

~~Get full test suite passing.~~
[x] Ask for feedback on new installation steps.

Closes #455?

migurski commented 9 years ago

I’d like to get this merged in spite of the test suite failures. After investigating, they don’t seem related to the changes made here, and I was able to get one of them to pass completely after retrying several times.

The failures seem to stem from stubby, and manifest immediately on login.

migurski commented 9 years ago

I’d love some feedback on the tweaks to README, otherwise I think this is good to merge.

tmaybe commented 9 years ago

regarding the README tweaks:

I would add a little more context in the setup of sample-site, what those commands are doing, why it's important to have a bare repository and why we want to change the remote name (and how to check to verify that it's been changed).
I would link to the Jekyll Install README in that step.

tmaybe commented 9 years ago

I reverted this merge from the command line with

git revert -m 1 a224f50e614e75ffa4d939a66fb93065e2c6f580

which created the commit e2f82c41bf42eba1a410af145a226814e8669362

tmaybe commented 9 years ago

I also clicked GitHub's Revert button above, which created the branch revert-481-resolve-gitpython-stderr-#455 but nothing was done with that branch.