search

codeforamerica / chime

A city-focused content management system
http://chimecms.org/
BSD 3-Clause "New" or "Revised" License
35 stars 12 forks source link

Upgraded GitPython to 1.0.1 #514

Closed migurski closed 8 years ago

migurski commented 8 years ago

Reprise of #481, possibly closes #455.

wpietri commented 8 years ago

This failed once on travis, and also isn't working right on my machine. I'm investigating.

tmaybe commented 8 years ago

I think this is ready, but would appreciate a sanity check on my changes.

The change in af54403 closes #493

wpietri commented 8 years ago

I like it and think it's a step forward. I think we really need to figure out some consistent place to handle encoding, though. Sprinkling UTF calls in many places is just asking for bugs; it's too easy to forget. Would switching to Python 3 help us here?

tmaybe commented 8 years ago

Yeah, I think these changes reflect the new version of GitPython acting in a Python 3 manner, so all reads/writes that are brokered by GitPython no longer need us to manually indicate encoding.

I'm open to porting to Python 3.

migurski commented 8 years ago

I am also open to porting. I propose an interim approach of adding Python 3 to our testing matrix so we have confidence that the code works there before we modify our various deployment things. I’ve found that testing in 3.x alone can introduce the benefits of 3.