codeforamerica / cityvoice

A place-based call-in system for gathering and sharing community feedback
MIT License
47 stars 35 forks source link

Location URL Fixup #188

Closed waltz closed 8 years ago

waltz commented 10 years ago

I changed URLS on locations to take advantage of a little Rails URL routing magic. It simplifies some of the location lookup and handles funky characters like ' and \ a bit better in exchange for a crufty set of digits before the title.

waltz commented 8 years ago

Merged as 4e2ae78cc299b26ccdd8b98de9ad27a10ac61d28. Hooray!

jmadans commented 8 years ago

Oh shit. So this fixes #242?! @waltz

waltz commented 8 years ago

You betcha! I updated the test suite to cover this case, so this shouldn't be a problem in the future. :balloon:

daguar commented 8 years ago

Fuck yeah testing.

On Nov 26, 2015, at 3:54 PM, CJ Bryan notifications@github.com wrote:

You betcha! I updated the test suite to cover this case, so this shouldn't be a problem in the future.

— Reply to this email directly or view it on GitHub.