search

codeforamerica / civic-issue-finder

UNMAINTAINED. An embeddable widget to find issues on the Code for America API
http://www.codeforamerica.org/geeks/civicissues
33 stars 15 forks source link

Show GitHub avatars on Issue cards #9

Closed ondrae closed 10 years ago

ondrae commented 10 years ago

Description

Show people! The guess is that Issues that have more people involved, will attract more people.

Mock Up

issue mock up

Shouts to @alanjosephwilliams for the idea.

ondrae commented 10 years ago

Wanting to get some discussion on if showing avatars at all is a good idea.

Whats better?

MatthewLoveless commented 10 years ago

I like the avatars, I think they humanize the issue. Slightly favor avatars of the committers. This also makes me think of ways to reward people for working on issues they find with the tracker.

ondrae commented 10 years ago

Ooooh I like having people on there too. Check it out live at http://www.codeforamerica.org/geeks/civicissues

migurski commented 10 years ago

The icons add a pretty substantial request overhead to the overall page. On my shitty inflight wifi, they draw out the loading time and keep the iframe artificially tiny for 10-15 seconds, a long period of time. Looks deeply broken.

squat

Since we know that they are square images we can define their sizes ahead of time and somehow get them out of the critical path until after load.

ondrae commented 10 years ago

I fixed it by doing as you suggested. The space for the avatars is reserved and then the pictures are loaded after the DOMContentLoaded event fires.

There was a second issue of the /geeks/civicissues page not having a height set for the embedded iframe. It still resizes itself but from 900px instead of 100px or whatever the default is.

Tested it on all the major browsers.

migurski commented 10 years ago

Is this deployed? I think it might be related to #22.