Closed lippytak closed 9 years ago
If anyone is interested in taking a stab at this, please ping me here first — this might have some complexity in terms of integrating with the larger app, so want to chat about it first.
We should try out filepicker.io. Just tried it out on Instacart:
Note the 'take a picture' option even on Desktop...huge perk!
S3 instructions: https://developers.filepicker.io/page/s3/
Filepicker.io support says:
Moved to current sprint. At the very least let's spec out this feature together this week.
Is a $49 - $99 fixed monthly cost in any way a blocker to this approach?
On Mon, Mar 2, 2015 at 1:47 PM, Jake Solomon notifications@github.com wrote:
Moved to current sprint. At the very least let's spec out this feature together this week.
— Reply to this email directly or view it on GitHub https://github.com/codeforamerica/clean/issues/365#issuecomment-76832960 .
t: @alanjosephwilli p: 817 713 6264
Heroku has 4 options for image processing (one is Filepicker):
Price isn't a blocker
On Tuesday, March 3, 2015, Dave Guarino notifications@github.com wrote:
Heroku has 4 options for image processing (one is Filepicker):
[image: screen shot 2015-03-03 at 1 35 55 pm] https://cloud.githubusercontent.com/assets/994938/6472891/66c9c88c-c1aa-11e4-9e0b-0f4d59f3911a.png
From https://addons.heroku.com/
— Reply to this email directly or view it on GitHub https://github.com/codeforamerica/clean/issues/365#issuecomment-77040751 .
I'm currently assessing the world of options across UX and technical needs.
So, here's my proposal for what I think we want to use for each of the components:
(In UX, User finalizes application and clicks submit here)
Might recommend shoving the images into redis over PG. You could store the images for each app in a list. But if you want to keep them around, S3 is probably best.
Will try and check out jquery-file-uploader tomorrow if I have time.
(work being done on the doc-upload-redux
branch):
insert YAKS / UNDERPANTS GNOMES here
MAYBE:
Added:
Done: Make it automatically upload (no start button)
Added: fix progress bar
Fixed the progress bar in a slightly hacky way — swapped out the jquery-file-upload plugin's progress bar with the simple jquery-ui one: https://jqueryui.com/progressbar/
Experience/design could use some improvement, but the plumbing is there now.
Edited the storage item — let's not use Postgres since Heroku's $50 tier caps at 64gb of storage, and S3 will work fine (even though I don't love schlepping files across HTTP twice.)
Added: - [ ] Secure uploads so that they're not publicly accessible
Finished: Attach unique key (per application) to the documents uploaded
Reorganized under some broad buckets
First pass at processing done
Done with links from prior screens
w00t! done with "Append all document images to the end of the application"
First successful use of it on my local box!
Link for "next step" done (but need to make it a nice button; ugh, css)
Added: Resize images so they're smaller (on a single page)
Done with processing images for PDF appending! The strategy is this:
Tested manually successfully with an iPhone.
woooot
On Thu, Apr 9, 2015 at 10:05 AM, Dave Guarino notifications@github.com wrote:
Done with processing images for PDF appending! The strategy is this:
- If the doc is a PDF, simply append it
- If the doc is an image (JPG, PNG, GIF), draw it on its own PDF page (resizing it to fit) and then append that PDF page
Tested manually successfully with an iPhone.
— Reply to this email directly or view it on GitHub https://github.com/codeforamerica/clean/issues/365#issuecomment-91293211 .
t: @alanjosephwilli p: 817 713 6264
Done with:
X - Store the location of the PDF in the database somewhere X - Make case has a Paperclip attachment with the final PDF X - Add has_attached_file to model X - Write a migration X - Try out the interface (what object does it expect?) X - Try it in full flow X - Delete zipping and attachment code X - Modify email body to put link to file
Done with using S3 for doc and PDF storage
Done with securing S3 URLs
Done with basic auth URL to give access to secured application PDFs for EWs
Merged in @alanjosephwilliams's front end work via #484
Successfully used on dev!
Two issues that came out of it (adding above as new tasks):
fit
method to resize is causing quality issues which made 1 test doc illegible; since we use MiniMagick now, the best approach is probably leaning on that for the resizing, and then leaning on Prawn to draw it to a PDF page with normal dimensionsSmall user pain today = when user had a problem and emailed RMInquiries about it instead of us. Oops! This isn't RM's job so let's do our best to get their email address down from the public asap. Onwards!
@daguar in the interest of chunkification, what are the remaining steps to launch? Check the QA issue for what I found: https://github.com/codeforamerica/clean/issues/486. LMK if you'd like me to make separate issues for the P1/P2 issues.
Checked off improvement of image quality (was #487)
Moved release checklist to https://github.com/codeforamerica/clean/issues/504
In addition to filling out the basic application form, users have to upload personal documents to go along with their application. This usually includes about 4-10 scanned documents (PDFs) or photos taken from a phone/tablet. At first we tried a one view per document approach and a circular flow ("do you want to upload anything else?") but a bulk uploader would be a lot better.
Let's try making one:
Resources:
Moved final launch checklist to: https://github.com/codeforamerica/clean/issues/504