QA document upload

[daguar]

DO IT

[lippytak]

Just some notes as I go. I'll turn these into issues or a checklist when done:

• If you click 'next step' before docs are finished uploading bad things happen.
• What happens if you click next step twice in a row?

Tests:

• [x] Same filenames
• [x] Various file types (error msg)
• [x] Upload some good and some bad things (good ones stay intact :+1: )
• [x] Multi-page PDFs
• [x] Big (5MB +) PDF file
• [x] Click next while file is uploading
• [x] Huge files
• [x] Diff/wrong extensions
• Mobile
  • [x] Basics
  • [x] From camera roll
  • [x] From camera roll + photos
  • [x] Panorama photos or weird photo types on phones
  • [x] On mobile connection
  • [x] 10 photos on mobile connection...find the limit!
• [x] Maaaaaaany files!
• [x] Same file a bunch of times
• [x] Doing things mid-upload (back, forward, next, new upload)
• [x] Crazy characters in filenames
• [ ] No extension (can't test on Mac)
• [x] Simultaneous uploads
• [x] Share link after a minute
• [ ] Other security
• Devices / Browsers
  • [x] Windows RT
  • [ ] Lower end Androids
  • [ ] IE 8
  • [x] Chrome
  • [x] Firefox
  • [x] Safari

P1 = Issues to fix before launch

• Clicking 'Next' during uploads > nothing gets uploaded
• Big files > 500 error on 'Submit Application'. Requires server restart. File seems to upload/process okay on the backend, though!
• Some (~5%) uploads get stuck if you start lots quickly. We should either fix or give a more graceful error so the user knows to try that doc again.

P2 = Issues to fix soon after

• Progress bar broken on mobile
• Unhelpful error messages

P3 = Nice to haves

• Clicking filename downloads a weird XML file
• Going forward then back shows no files (but they still get uploaded)
• Specific/different error messages for each error case. For example here's one with incorrect file extension:
• Sometimes docs are included out-of-order. Could possibly be important for folks who takes pics in a specific...for example a 2 page letter.
• Future consideration is how to speed things up on a mobile connection. One option is to resize on the client-side: http://stackoverflow.com/questions/10333971/html5-pre-resize-images-before-uploading

[alanjosephwilliams]

Liliana tried to upload a powerpoint :)

[lippytak]

Got stuck when uploading ~25 files

[lippytak]

Error logs on mobile after 'Submit App' >

2015-04-18T14:38:55.302283+00:00 app[web.1]: UUID: 1401433864075802802 2015-04-18T14:38:55.302285+00:00 app[web.1]: URL: https://airbrake.io/locate/1401433864075802802 2015-04-18T14:38:55.303566+00:00 app[web.1]: 2015-04-18T14:38:55.303569+00:00 app[web.1]: NoMethodError (undefined method length' for nil:NilClass): 2015-04-18T14:38:55.303572+00:00 app[web.1]: app/controllers/application_controller.rb:163:inreview_and_submit_submi

[lippytak]

UI issue with long filenames:

[lippytak]

Uploads get stuck ~5% of the time:

[lippytak]

P1/P2 bugs are now issues: https://github.com/codeforamerica/clean/issues/494 https://github.com/codeforamerica/clean/issues/495 https://github.com/codeforamerica/clean/issues/496 https://github.com/codeforamerica/clean/issues/497 and https://github.com/codeforamerica/clean/issues/498

And the release checklist in the OG issue: https://github.com/codeforamerica/clean/issues/365

[daguar]

Checked off Windows RT because Liliana tested it

[daguar]

@lippytak there's a few more unchecked QA boxes above; should we re-open this?