codeforamerica / codeforamerica.org-archive

The (former) @codeforamerica website
http://archive.codeforamerica.org
Other
176 stars 135 forks source link

Inline styles causing horizontal scrolling #466

Open maban opened 10 years ago

maban commented 10 years ago

On the homepage, there's an inline style "ul.list-logos{ width:900px; … }" that cuts off the logos at the bottom of the page if the window is made smaller. This should be changed to {max-width:900px}.

Is there a reason these are inline, were they to fix any problems? Can I help by moving these styles to the CSS files?

migurski commented 10 years ago

Yes, I believe @phae and @mattboitan0 put them there to tweak the donor logos in the footer of the page. I don't recall the intent of the tweak, I think it was to pull them together somewhat.

phae commented 10 years ago

Basically, Matt and his team now want full control over donors and what donors go on which line (top line paid most, 2nd a bit less, etc.).

phae commented 10 years ago

We were trying out that layout, and I was going to update the styles if that suited their needs, but now thinking about it, it probably won't be robust enough for their changing sponsors over time.

maban commented 10 years ago

I could build a new pattern – perhaps having bigger logos at the top and smaller ones in more columns on the next rows.

migurski commented 10 years ago

:+1:

maban commented 10 years ago

I've created a pattern based on the list of logos, and you can choose between 3 different sizes to apply to the list.

Big screen: screen shot 2014-08-06 at 13 13 54

Little screen: screen shot 2014-08-06 at 13 14 12

phae commented 10 years ago

Oh, that's cool!