search

codeforamerica / courtbot

Your friendly neighborhood court robot. Provides an api for getting court case information.
ISC License
44 stars 55 forks source link

Add tests #1

Closed junosuarez closed 9 years ago

junosuarez commented 10 years ago

@pui reached out and I'm happy to help with this - @samhashemi would you be interested in pairing at some point? Let's roll up our sleeves! :umbrella:

samhashemi commented 10 years ago

I gotta spend tomorrow morning switching from the PDF scraping to a new CSV data source. If it goes well, I might have time to pair in the afternoon. I'll let you know.

But if you want to take a head start and test some of the texting/querying stuff, I won't complain!

junosuarez commented 10 years ago

Cool. Let me also recommend binary-csv over the current csv-parse module you're using.

samhashemi commented 10 years ago

I'll take a look. It you want to pair on the CSV this morning, grab me on Slack.

samhashemi commented 10 years ago

@jden available today?

junosuarez commented 10 years ago

@samhashemi I've got some external communication I'm catching up on this afternoon, might be available this evening (I'm 3 hours ahead of you, etc etc)

samhashemi commented 9 years ago

The refactor branch now has a set of tests.

sb8244 commented 9 years ago

@samhashemi where is the refactor branch at? I'm looking at deploying this for Code for Atlanta and wanted some tests to get in there and have confidence in changes. Will it be merged back into master?

samhashemi commented 9 years ago

@sb8244 it's been a while, so I'm not sure. I think big chunks of the functionality are there, but a few pieces were missing. Looking at the tests, a few of the reminders ones are commented out, so that's probably what still needs to be added.

I'm not actively working on the project any more, so you'd have to finish it up and confirm things are working to merge it in.

sb8244 commented 9 years ago

Thanks. I might just look into re-doing the refactor on the current master (forked to CFAtl) and learn/grow the codebase that way.

sb8244 commented 9 years ago

Wrote some hacky tests. Minimal code change while having decent code coverage: https://github.com/codeforatlanta/courtbot/tree/master/test

Is there any chance to migrate this over to CodeForAtlanta main? It seems weird to have the fork be the new main codebase.