Closed gregoryjscott closed 10 years ago
@boonrs This is ready for a code review.
This looks good to me and I'd like to merge once the namespace is added. I plan to add the following issues as a result of this review:
Namespace was added, Gemfile was removed (different PR coming soon), and commits are now cleanish. This should be good to go now.
This adds a new resource API of
/reminders/email/send
.POST /reminders/email/send
represents the "act of sending" and the Send resource represents the data associated to this act, such asstartRemindOnDateTime
andendRemindOnDateTime
.These are the concepts (I think).
/reminders/email/send
.POST /reminders/email/send
.The code added is currently using these conventions, but is still a work in progress.
SendModule
POST /reminders/email/send
Send
- stores the data associated to this API's act of sendingPostRemindersEmailSend
- which matches up to the operation of SendSendEmails
- sub-task for sending emailsRemindersEmailSendTests
- test class responsible for integration testing the/reminders/email/send
operations (currently only one - POST)PostRemindersEmailSendTests
- tests forPostRemindersEmailSend
task (exact purpose is TBD)SendEmailsTest
- tests forSendEmails
subtaskTodo
Determine if "Trigger" is the appropriate resource nameIt wasn't.