codeforamerica / denver-schedules-api

An api for city events & schedules.
MIT License
7 stars 5 forks source link

Create API endpoint to trigger reminder emails #16

Closed gregoryjscott closed 10 years ago

gregoryjscott commented 10 years ago

This adds a new resource API of /reminders/email/send. POST /reminders/email/send represents the "act of sending" and the Send resource represents the data associated to this act, such as startRemindOnDateTime and endRemindOnDateTime.

These are the concepts (I think).

The code added is currently using these conventions, but is still a work in progress.

Todo

gregoryjscott commented 10 years ago

@boonrs This is ready for a code review.

boonrs commented 10 years ago

This looks good to me and I'd like to merge once the namespace is added. I plan to add the following issues as a result of this review:

gregoryjscott commented 10 years ago

Namespace was added, Gemfile was removed (different PR coming soon), and commits are now cleanish. This should be good to go now.