search

codeforamerica / fast_pass

Las Vegas Development Opportunity Finder
BSD 3-Clause "New" or "Revised" License
7 stars 4 forks source link

Upgrading to the latest version of angular (1.2.5) breaks directives #90

Closed lovehandle closed 10 years ago

lovehandle commented 10 years ago

I upgraded angular to the latest release (1.2.5) and one of the directives no longer works (max words). This upgrade may break other components too that I'm not aware of. Also, 1.3.0 is going to be released soon (allegedly). It may be good to go over the site with a fine-toothed comb to ensure that nothing else broke that we're aware of.

@louh something to be aware of....

louh commented 10 years ago

Got it - I'll go through once more and see what happens with the latest Angular. The max-words directive is not important to the user experience (but it came as a suggestion from someone) and I'll file a separate issue for it so that I can take a look at it later.

louh commented 10 years ago

A comment about Angular 1.3 - it will remove compatibility with IE8 (see this blog post). While there's nothing I would like better than to nudge the city toward end-of-lifing their use of IE8, I'll shoot an e-mail to them to verify that it's something we can go forward with.

louh commented 10 years ago

From the City:

...we are migrating from IE8 and will be completed by April 2014.

Currently we are testing IE10 and IE11 in our environment, but we also plan to deploy Chrome enterprise wide as an alternative.

Given that the audience is not really for City employees but for potential licensees, I think it’s a safe bet that we don’t need to sweat compatibility with IE8 too much.

@rclosner Should we agree to close this and continue to open new issues as necessary if/when we detect specific breakages?

louh commented 10 years ago

(e.g.) I filed #92, and so far that's the only other broken directive I've seen.

lovehandle commented 10 years ago

Agreed.