codeforamerica / follow-all

Follow all the members of a Twitter list with a single click
http://follow-all.herokuapp.com/
BSD 3-Clause "New" or "Revised" License
81 stars 31 forks source link

Display users to follow on sessions#show #8

Open lovehandle opened 11 years ago

lovehandle commented 11 years ago

Not an issue, but a feature (maybe?). It would be nice to see exactly who you are about to follow prior to following a list of some indeterminate number of users.

I'll submit a pull request if this attracts any interest.

bensheldon commented 11 years ago

My $0.02: that would be awesome.

On Monday, January 7, 2013, Ryan Closner wrote:

Not an issue, but a feature (maybe?). It would be nice to see exactly *who

  • you are about to follow prior to following a list of some indeterminate number of users.

I'll submit a pull request if this attracts any interest.

— Reply to this email directly or view it on GitHubhttps://github.com/codeforamerica/follow-all/issues/8.

Ben Sheldon 2012 Fellow @ Code for America ben@codeforamerica.org 415.275.1776

lovehandle commented 11 years ago

Sketched out a basic interface to view followers (prior to following) using Backbone.js. Haven't hooked it up to the API yet (the limit on API calls without any Sandbox option really turned out to be a bitch), but if you go to /twitter_show you can see the general idea. Would love feedback if anyone wants to check it out.

Branch is: https://github.com/rclosner/follow-all/tree/backbone

sferik commented 11 years ago

I tried checking out your branch but I'm getting the error:

ActionView::Template::Error (require_tree argument must be a directory
(in /Users/sferik/Projects/Ruby/apps/tmp/follow-all/app/assets/javascripts/application.js:26))

That line reads:

//= require_tree ./routers

Perhaps you forgot to add and commit that directory? Removing that line fixes the problem.

sferik commented 11 years ago

Is it supposed to look like this?

Screen Shot 2013-01-08 at 5 40 28 PM

lovehandle commented 11 years ago

I just added 500 stock accounts for each list. Didn't want to connect it to a live feed yet. Hope you enjoy the vanity list.

I'm thinking about adding name and screen name next to each image? Thoughts?

lovehandle commented 11 years ago

Also, I did indeed miss the routers dir. My bad. WIP.

sferik commented 11 years ago

I actually think the numbers in the aggregate are more interesting that the individual profiles. Before someone taps the “Follow All” button, they probably want to know: “How many new accounts will I be following?” as opposed to “Specifically which 20 accounts will I be following?” Even if you only wanted to follow 19 of the 20, there’s currently no way to do that. Perhaps the interface could show you all the members of a list and then let you pick and choose who to follow but that sounds too complicated to me. The whole point of “Follow All” is the simplicity of following a list of people with a single click. It’s intentionally not a power tool.

sferik commented 11 years ago

Oops! I accidentally clicked "Close & Comment".

lovehandle commented 11 years ago

I agree with that. I think the case in which one would want to follow an entire list- sans one or two people- would be rare. At the very least, I would like to add usernames adjacent to the image. I see value in adding the number of followers somewhere in the view as well.

lovehandle commented 11 years ago

Updated view of my backbone branch:

follow-all

Thoughts?

lovehandle commented 11 years ago

@bensheldon Backbone.js debugging question: I have an event binding defined (that is clearly being set), but it refuses to run the callback when it's triggered (even when I attempt to run model.trigger("event")). No errors are being raised, and I have no idea how to begin debugging it. Thoughts?

https://github.com/rclosner/follow-all/blob/backbone/app/assets/javascripts/models/twitter/follow_all.js.coffee#L8

bensheldon commented 11 years ago

I'm not the best with CoffeeScript, but it doesn't appear that you're actually attaching onUserChange to your initialize function (I think you're returning a hash from the initialize function rather than defining @onUserChange). So I think you're indentation is screwed up. ...though instill think it should throw an error because it will find that function to be undefined.

In terms of debugging, I would try attaching a console logging statement to your event and just seeing if you can get it to trigger in the first place. This is also a really simple test pattern for backbone: spy on a function, trigger the emitter, and see if the spied on function is called.

If any of this makes any sense...

On Wednesday, January 9, 2013, Ryan Closner wrote:

@bensheldon https://github.com/bensheldon Backbone.js debugging question: I have an event binding defined (that is clearly being set), but it refuses to run the callback when it's triggered (even when I attempt to run model.trigger("event")). No errors are being raised, and I have no idea how to begin debugging it. Thoughts?

https://github.com/rclosner/follow-all/blob/backbone/app/assets/javascripts/models/twitter/follow_all.js.coffee#L8

— Reply to this email directly or view it on GitHubhttps://github.com/codeforamerica/follow-all/issues/8#issuecomment-12074030.

Ben Sheldon 2012 Fellow @ Code for America ben@codeforamerica.org 415.275.1776

lovehandle commented 11 years ago

Indentation fail. I am an iziot.

i am an idiot

Thanks!