search

codeforamerica / git-jekyll-preview

Preview your Github-hosted websites before making them live.
http://jekit.codeforamerica.org
29 stars 17 forks source link

Does not preview branches with `/` in name #16

Open dmsnell opened 8 years ago

dmsnell commented 8 years ago

I was trying to preview some changes at https://jekit.codeforamerica.org/codefortucson/codefortucson-site/add/focus-pages/ for the branch, add/focus-pages and received the following error:

Jekit Error Couldn’t find add under codefortucson/codefortucson-site. Does it exist?

Presumably this is because of the / in the branch name. I'm not sure how a good way to fix this would be since there can also be legitimate links after the branch name.

migurski commented 8 years ago

This is an issue I ran into after moving to Mapzen last year. The fix took a bit of effort, but it exists in our fork of this app called Precog: https://github.com/mapzen/precog

We made a big trade off to ditch the need for a server running Jekyll in favor of using build artifacts from CircleCI. You can try it at https://precog.mapzen.com with your own repo if you'd like.

On Jul 17, 2016, at 10:10 PM, Dennis Snell notifications@github.com wrote:

I was trying to preview some changes at https://jekit.codeforamerica.org/codefortucson/codefortucson-site/add/focus-pages/ for the branch, add/focus-pages and received the following error:

Jekit Error Couldn’t find add under codefortucson/codefortucson-site. Does it exist?

Presumably this is because of the / in the branch name. I'm not sure how a good way to fix this would be since there can also be legitimate links after the branch name.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.