Footer is offset for all tablet-up screens - Githubissues

codeforamerica / honeycrisp-gem

A Rails gem with base styles and Javascript for Code for America products

http://honeycrisp.herokuapp.com

MIT License

26 stars 8 forks source link

Footer is offset for all tablet-up screens #212

Closed luigi closed 3 years ago

luigi commented 4 years ago

Saw this on our Pandemic EBT apps:

Apply_for_P-EBT__Pandemic_EBT_

View it live: https://ca-demo.p-ebt.org/en/

I think this issue popped up because of some recent sidebar work:

https://github.com/codeforamerica/honeycrisp-gem/blob/7430ee20b4535f73c46f47b62cf8f4d80698c0ce/app/assets/stylesheets/_sidebar-nav.scss#L171-L173

The left: $sidebar-width rule is being applied to all tablet-up instances of .main-footer, even in cases where the sidebar isn't present.